Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1476#discussion_r15133407
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -75,7 +75,9 @@ class TaskMetrics extends Serializable {
/**
* If this task reads from shuffle output, metrics on getting shuffle
data will be collected here
*/
- var shuffleReadMetrics: Option[ShuffleReadMetrics] = None
+ private var _shuffleReadMetrics: Option[ShuffleReadMetrics] = None
+
+ def shuffleReadMetrics = _shuffleReadMetrics
--- End diff --
I was trying to force people to use updateShuffleReadMetrics() rather than
directly updating shuffleReadMetrics to avoid accidentally overwriting existing
values...happy to do this in a different way though if you think something else
would be better / more readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
