Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1476#discussion_r15123302
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -527,8 +527,9 @@ private[spark] object JsonProtocol {
metrics.resultSerializationTime = (json \ "Result Serialization
Time").extract[Long]
metrics.memoryBytesSpilled = (json \ "Memory Bytes
Spilled").extract[Long]
metrics.diskBytesSpilled = (json \ "Disk Bytes Spilled").extract[Long]
- metrics.shuffleReadMetrics =
- Utils.jsonOption(json \ "Shuffle Read
Metrics").map(shuffleReadMetricsFromJson)
+ Utils.jsonOption(json \ "Shuffle Read Metrics").map {
shuffleReadMetrics =>
+
metrics.updateShuffleReadMetrics(shuffleReadMetricsFromJson(shuffleReadMetrics))
--- End diff --
Not sure if you need to do this here, since we're creating a TaskMetrics
from scratch anyway
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
