Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12413#issuecomment-210868252
The title is somewhat misleading. 95% of the change is removing extra
layers of braces. There are a few instances where types were removed where they
appeared redundant, along the way. "Inappropriate" isn't quite the right word;
maybe superfluous. No style rules have been added (see PR), though he wrote
down what he tried but didn't enact.
So the question is about things like this?
```
new JavaDoubleRDD(rdd.flatMap(fn).map((x: jl.Double) => x.doubleValue()))
```
becoming
```
new JavaDoubleRDD(rdd.flatMap(fn).map(_.doubleValue()))
```
?
In the method, `fn` is already known to produce `jl.Double` so this is
redundant. It does not add type safety that I can see. I supported removing a
few instances of this type merely to make it more readable. The others are in
examples, where they show user code with these types that aren't necessary.
If I missed a reason for that -- or if you just really want that type --
those changes are minor either way and could be undone. But I reviewed all the
changes again and they look correct as intended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
