Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12413#issuecomment-210871996
The type isn't that obvious, but it's also not necessary code-wise or to
understand the example. I think. Generally the code doesn't write these types
of course. This is an example however, for people to learn from. But, I also
see most examples don't write types in this case. Seems reasonable to be
consistent.
I suggested the further changes to lines that were being changed already
(cf. above). There are some additional changes sort of in the same spirit that
were not on lines already being modified for the core purpose of the change.
Each of the changes looks OK to me, but the gain is very small. If I could wave
a wand and make all the code follow one style -- it would be of the sort
reflected in this change. We're not going to literally do that, but chipping a
way a little is a tiny net improvement.
While I don't think it's worth modifying further, and certainly not undoing
the core `{{...}}` changes, I wouldn't object if you undo the other changes, if
you feel strongly. The `blame` "damage" is done, I'm afraid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
