Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12413#issuecomment-210868609
How is the type "(rdd: RDD[(String, Int)], time: Time)" obvious? I'd rather
roll that back. But more importantly, while I think it is worthwhile to get the
codebase to some consistent style (e.g. the `{{` one is good), some of the
things changed in this pr (the ones that removed explicit typing, or replaced
`x =>` with `_.` are very questionable. They don't really improve clarity or
achieve any consistency (because we have tons of other places that are using
either style).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
