Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12413#discussion_r59972540
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -431,7 +431,7 @@ private[sql] object StatFunctions extends Logging {
s"exceed 1e4. Currently $columnSize")
val table = counts.groupBy(_.get(0)).map { case (col1Item, rows) =>
val countsRow = new GenericMutableRow(columnSize + 1)
- rows.foreach { (row: Row) =>
+ rows.foreach { row =>
--- End diff --
I agree the type isn't obvious, but that can't be the standard, or else
we'd write types almost everywhere in Scala. While I don't see the reason this
is a special case (you identify a decent reason right above though), I also
would not have changed it just for its own sake. I personally would accept the
change if the line were being modified, but it wasn't. Hence on a second look
I'd be neutral, and wouldn't oppose undoing this, even if I think it's really 6
of one, half-dozen of the other.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
