Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12413#discussion_r59972081
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -431,7 +431,7 @@ private[sql] object StatFunctions extends Logging {
s"exceed 1e4. Currently $columnSize")
val table = counts.groupBy(_.get(0)).map { case (col1Item, rows) =>
val countsRow = new GenericMutableRow(columnSize + 1)
- rows.foreach { (row: Row) =>
+ rows.foreach { row =>
--- End diff --
Yeah, but there are a thousand places in the code where a local val's type
isn't obvious (e.g. what's `rows` above?). The question is readability, and I
do agree this isn't obviously better on that dimension. I wouldn't have touched
it for its own sake. I scanned this as a line where we were already changing
the braces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
