Github user ericl commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213088884
@vanzin scalastyle has this option to not fail the task on error. The
problem I ran into with this was with SBT task caching, which hides the
warnings if you ever compiled the code before. This didn't seem very friendly
since your output was basically unpredictable. Also I think warnings tend to
get lost since there are a lot of other ones in the build already.
I opted to just turn the `println` thing into a warning on compile, keeping
everything else as an error. I think this is probably fine because most
developers remember to remove their debug prints before submitting code for
review, but more easily forget other style nits.
The current implementation is a hacky search-and-replace in the xml, but
this seemed more maintainable than copying the entire xml file. The way it's
done now you get a sbt error if the replacement ever fails, so it will not
break easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
