Github user ericl commented on the pull request:
https://github.com/apache/spark/pull/12555#issuecomment-213119021
Most of the code in `cachedScalaStyle` is just the boilerplate needed to
call scalastyle manually. The caching code is only a few lines supporting the
FileFunctions.cached call (it's a built-in sbt function:
http://www.scala-sbt.org/0.13.0/docs/faq.html).
We could remove the task caching code, however this significantly impacts
incremental compile time (when I evaluated it, `~compile` went up from 3s ->
8s, and would go up more on slower machines).
Since the purpose of the sbt build is to support faster iteration in dev, I
think it's worth the lines to give immediate style feedback. I don't quite buy
the complexity argument here, since the added code is self-contained and does
not impact other components.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
