Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/1704#discussion_r15979804
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -85,22 +85,46 @@ class StreamingContext private[streaming] (
master: String,
appName: String,
batchDuration: Duration,
- sparkHome: String = null,
- jars: Seq[String] = Nil,
- environment: Map[String, String] = Map()) = {
+ sparkHome: String,
+ jars: Seq[String],
+ environment: Map[String, String]) = {
this(StreamingContext.createNewSparkContext(master, appName,
sparkHome, jars, environment),
null, batchDuration)
}
+ def this(
+ master: String,
+ appName: String,
+ batchDuration: Duration) =
+ this(master, appName, batchDuration, null, null, Map())
+
+ def this(
+ master: String,
+ appName: String,
+ batchDuration: Duration,
+ sparkHome: String) =
+ this(master, appName, batchDuration, sparkHome, null, Map())
+
+ def this(
--- End diff --
Hey, I think these changes are unnecessary.
```diff
@@ -95,10 +95,17 @@ class StreamingContext private[streaming] (
/**
* Recreate a StreamingContext from a checkpoint file.
* @param path Path to the directory that was specified as the
checkpoint directory
+ */
+ def this(path: String) =
+ this(null, CheckpointReader.read(path, new SparkConf(), new
Configuration).get, null)
+
+ /**
+ * Recreate a StreamingContext from a checkpoint file.
+ * @param path Path to the directory that was specified as the
checkpoint directory
* @param hadoopConf Optional, configuration object if necessary for
reading from
* HDFS compatible filesystems
*/
- def this(path: String, hadoopConf: Configuration = new Configuration) =
+ def this(path: String, hadoopConf: Configuration) =
this(null, CheckpointReader.read(path, new SparkConf(),
hadoopConf).get, null)
if (sc_ == null && cp_ == null) {
```
I was able to compile w/o errors with just above patch for
`StreamingContext`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
