Github user avati commented on a diff in the pull request:
https://github.com/apache/spark/pull/1704#discussion_r15980421
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -85,22 +85,46 @@ class StreamingContext private[streaming] (
master: String,
appName: String,
batchDuration: Duration,
- sparkHome: String = null,
- jars: Seq[String] = Nil,
- environment: Map[String, String] = Map()) = {
+ sparkHome: String,
+ jars: Seq[String],
+ environment: Map[String, String]) = {
this(StreamingContext.createNewSparkContext(master, appName,
sparkHome, jars, environment),
null, batchDuration)
}
+ def this(
+ master: String,
+ appName: String,
+ batchDuration: Duration) =
+ this(master, appName, batchDuration, null, null, Map())
+
+ def this(
+ master: String,
+ appName: String,
+ batchDuration: Duration,
+ sparkHome: String) =
+ this(master, appName, batchDuration, sparkHome, null, Map())
+
+ def this(
--- End diff --
@scrapcodes - yes removing in one place should be sufficient, but it is
probably a better thing to do to not use default params in places you want to
provide ABI compatibility in the long run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
