Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/1704#discussion_r15979913
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -85,15 +85,28 @@ private[spark] object JettyUtils extends Logging {
path: String,
servletParams: ServletParams[T],
securityMgr: SecurityManager,
- basePath: String = ""): ServletContextHandler = {
+ basePath: String): ServletContextHandler = {
createServletHandler(path, createServlet(servletParams, securityMgr),
basePath)
}
+ def createServletHandler[T <% AnyRef](
+ path: String,
+ servletParams: ServletParams[T],
--- End diff --
This patch can also be simplified as
```diff
@@ -93,7 +93,7 @@ private[spark] object JettyUtils extends Logging {
def createServletHandler(
path: String,
servlet: HttpServlet,
- basePath: String = ""): ServletContextHandler = {
+ basePath: String): ServletContextHandler = {
val prefixedPath = attachPrefix(basePath, path)
val contextHandler = new ServletContextHandler
val holder = new ServletHolder(servlet)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
