Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213064103
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesDriverSpec.scala
---
@@ -24,8 +24,9 @@ private[spark] case class KubernetesDriverSpec(
systemProperties: Map[String, String])
private[spark] object KubernetesDriverSpec {
- def initialSpec(initialProps: Map[String, String]): KubernetesDriverSpec
= KubernetesDriverSpec(
- SparkPod.initialPod(),
- Seq.empty,
- initialProps)
+ def initialSpec(initialConf:
KubernetesConf[KubernetesDriverSpecificConf]): KubernetesDriverSpec =
+ KubernetesDriverSpec(
+ SparkPod.initialPod(),
+ Seq.empty,
--- End diff --
NIT: For clarity can you write as:
```
KubernetesDriverSpec(
SparkPod.initialPod(),
driverKubernetesResources = Seq.empty,
initialConf.sparkConf.getAll.toMap)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
