Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212760156
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config extends Logging {
"Ensure that major Python version is either Python2 or Python3")
.createWithDefault("2")
+ val KUBERNETES_DRIVER_CONTAINER_NAME =
+ ConfigBuilder("spark.kubernetes.driver.containerName")
--- End diff --
Wait, I don't think there's an existing configuration option. I believe the
container name is currently just hard coded in `Constants`.
However, I see your concern about using
`spark.kubernetes.driver.containerName` for multiple purposes. In that case,
it's definitely easier to reason about with fewer moving pieces, and it sounds
like simplest is best. I'll remove the container name configuration and just
stick with first container = driver container. This just means that the only
way to configure the container name will be through a pod template. I'll also
clarify in the docs
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
