Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r212722242
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ---
    @@ -225,6 +225,18 @@ private[spark] object Config extends Logging {
             "Ensure that major Python version is either Python2 or Python3")
           .createWithDefault("2")
     
    +  val KUBERNETES_DRIVER_CONTAINER_NAME =
    +    ConfigBuilder("spark.kubernetes.driver.containerName")
    --- End diff --
    
    Is there confusion because there's an _existing_ configuration option also? 
I think the existing configuration option sets the driver container name when 
no yml is specified. But perhaps the interpretation of this configuration value 
should change when the pod template is provided.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to