Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r212724020
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ---
    @@ -225,6 +225,18 @@ private[spark] object Config extends Logging {
             "Ensure that major Python version is either Python2 or Python3")
           .createWithDefault("2")
     
    +  val KUBERNETES_DRIVER_CONTAINER_NAME =
    +    ConfigBuilder("spark.kubernetes.driver.containerName")
    --- End diff --
    
    Yes, the semantic of this key will change with the template option. So with 
the template, there're two sources of driver container name, and we need to 
resolve conflicts in certain cases, e.g., if the name is specified in only one 
source or if the two sources mismatch.   


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to