Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212721068
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config extends Logging {
"Ensure that major Python version is either Python2 or Python3")
.createWithDefault("2")
+ val KUBERNETES_DRIVER_CONTAINER_NAME =
+ ConfigBuilder("spark.kubernetes.driver.containerName")
--- End diff --
Similarly, what if the user gives the driver container name in the driver
template but forgets to specify `spark.kubernetes.driver.containerName`?
Requiring users to set the container name explicitly and additionally through
another config key sounds a bit awkward to me, particularly when there's only
the Spark container itself.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]