rdblue commented on a change in pull request #24233: [SPARK-26356][SQL] remove SaveMode from data source v2 URL: https://github.com/apache/spark/pull/24233#discussion_r271023428
########## File path: sql/core/src/main/java/org/apache/spark/sql/sources/v2/TableProvider.java ########## @@ -24,7 +24,7 @@ /** * The base interface for v2 data sources which don't have a real catalog. Implementations must - * have a public, 0-arg constructor. + * have a public, 0-arg constructor, and can only deal with existing tables. Review comment: The phrase "deal with" is not very specific. I think it would be better to say what these tables can be used for: data operations like read, append, delete, and overwrite. Not operations that require metadata changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
