rdblue commented on a change in pull request #24233: [SPARK-26356][SQL] remove
SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r271395188
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopSuite.scala
##########
@@ -54,7 +56,7 @@ class NoopSuite extends SharedSQLContext {
accum.add(1)
x
}
- .write.format("noop").save()
+ .write.format("noop").mode("append").save()
Review comment:
Okay, then I think this PR depends on the PR to make append the default mode
for v2. Please get that in first.
Otherwise, this PR will make unnecessary changes to several places and we
will have to roll those changes back to make append the default mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
