rdblue commented on a change in pull request #24233: [SPARK-26356][SQL] remove
SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r271025332
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -25,14 +25,13 @@ import org.apache.spark.{SparkEnv, SparkException,
TaskContext}
import org.apache.spark.executor.CommitDeniedException
import org.apache.spark.internal.Logging
import org.apache.spark.rdd.RDD
-import org.apache.spark.sql.SaveMode
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.Attribute
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode}
import org.apache.spark.sql.sources.{AlwaysTrue, Filter}
import org.apache.spark.sql.sources.v2.SupportsWrite
-import org.apache.spark.sql.sources.v2.writer.{BatchWrite, DataWriterFactory,
SupportsDynamicOverwrite, SupportsOverwrite, SupportsSaveMode,
SupportsTruncate, WriteBuilder, WriterCommitMessage}
+import org.apache.spark.sql.sources.v2.writer.{BatchWrite, DataWriterFactory,
SupportsDynamicOverwrite, SupportsOverwrite, SupportsTruncate, WriteBuilder,
WriterCommitMessage}
Review comment:
I don't agree with this.
Wildcard imports make it difficult to cherry-pick commits and increase
conflicts. It is also difficult to see where symbols are coming from and
pollutes the namespace with everything in a package instead of just the
required names.
For example, I recently hit problems adding a `logical` package for
expressions because of places that imported `expressions._` along with
`plans._`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
