rdblue commented on a change in pull request #24233: [SPARK-26356][SQL] remove
SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r271395965
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -267,6 +266,23 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Implicits._
provider.getTable(dsOptions) match {
+ // TODO: for backward compatibility reasons, the builtin file source
needs to support all
+ // the save modes, which violates the semantic of `TableProvider`.
Here we special-case
+ // file source and pass the save mode to file source directly. This
hack can be removed
+ // after we figure out a general interface for path-based data sources.
+ case table: FileTable =>
Review comment:
File sources do not use v2 by default, so this is not a necessary change for
this commit. I think it should be in a separate PR. We can discuss whether it
is a good idea to add this hack in the next DSv2 sync.
Please remove it from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
