On 05/09/2014 05:37 AM, Ted Felix wrote: > How many of these changes are Qt4 compatible would you guess? Would > it be worth going through these one by one and evaluating them for Qt4 > compatibility, then applying them now? Or do you think very few could > be applied?
I'm thinking it would be wise to hold off applying any of these changes to the main code, until there are more people out there with Qt5 installed who can help evaluate this stuff. I did think it would be great to have something that would run on both Qt4 and Qt5, so I avoided Qt5-specific code wherever possible. And in the couple of cases where I could find no Qt4-compatible workaround, I used "#if QT_Version >= 0x050000" conditionals. The modified package does indeed compile and run on qt-4.8.5 as well as qt-5.2.0, but I can't vouch for its stability. Some gotchas may still lurk therein. The smaller changes probably present no problems, as in many cases they are direct replacements for constructs that are already deprecated in Qt4. One of the larger changes involves ThornStyle, which is now subclassed directly from QCommonStyle, as QPlastiqueStyle no longer exists. This works surprisingly well but could probably do with additional polish. By far the ugliest large change involves preserving the remote-url capability of the FileSource class. Because QHttp and QFtp have been dropped from Qt5 with no direct replacements offered, I have cobbled together HTTP and passive-FTP clients, using the low-level QTcpSocket class directly. These seem to work, but I can't find anywhere in Rosegarden where this functionality is ever actually called for. It's probably one of those relics from the Kde3 version that didn't survive the transition to Qt4. Until Qt5 becomes more widely available, this work should probably be regarded as reference material for use in the future. Tim Munro ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
