#3337: [with spkg, needs work] Upgrade gap-guava to new 4.4.12/3.9 release
-------------------------+--------------------------------------------------
Reporter: tabbott | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: packages | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by mabshoff):
* summary: [with spkg, needs review] Upgrade gap-guava to new 4.4.12/3.9
release => [with spkg, needs work] Upgrade gap-
guava to new 4.4.12/3.9 release
Comment:
Replying to [comment:29 wdj]:
>
>
> > * test the spkg on sage.math since there all the tests involving
Maxima pass
>
>
> Done. Modulo the maxima problems I have, it fails in the same way -
there are lots of funny
> print statements in gap.py which yield test output such as
>
> I don't understand the purpose of this print statement but it seems to
be fairly new.
This is not the problem I am referring to and the print issue were actual
changes in GAP's output. These need to be fixed. I have never seen the
above statement on sage.math. Which Sage release is this? Do you have
anything in .gaprc?
>
> > The spkg cannot be merged without fixing a large number of printing
issues with the doctests.
>
> Can the print statement in gap.py just be commented out?
>
I doubt it, but you should ask someone who knowns the code better.
This is wrong by the way:
{{{
if [ $UNAME = "CYGWIN" ]; then
+ echo "** Cygwin install not supported **"
$MKDIR bin
}}}
You also managed to delete .hgignore and not check in the changes to spkg-
install:
{{{
M spkg-install
! .hgignore
}}}
I do not understand why it is such a problem to make two two line changes
and check in the changes without breaking the spkg?
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3337#comment:30>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---