#3337: [with spkg, needs work] Upgrade gap-guava to new 4.4.12/3.9 release
-------------------------+--------------------------------------------------
Reporter: tabbott | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: packages | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by mabshoff):
* summary: [with spkg, needs review] Upgrade gap-guava to new 4.4.12/3.9
release => [with spkg, needs work] Upgrade gap-
guava to new 4.4.12/3.9 release
* milestone: sage-3.3 => sage-3.4.1
Comment:
David,
I am seeing doctest failures in
{{{
sage -t -long devel/doc/const/const.tex # 3 doctests failed
sage -t -long devel/sage/sage/matrix/matrix_integer_dense.pyx # 1
doctests failed
sage -t -long devel/sage/sage/coding/guava.py # 1 doctests failed
sage -t -long devel/sage/sage/coding/code_constructions.py # 8
doctests failed
sage -t -long devel/sage/sage/coding/linear_code.py # 16 doctests
failed
}}}
You implied that all problems had been addressed, but this was clearly not
the case. If you doctested your patches and they do not pass doctest do
not mark them ready for review since at least on your test box all tests
should pass. If they did I am very surprised, but at least the const.tex
failure does happen regardless. Please make sure that in the future you
also test the documentation since this issue has cropped up repeatedly via
patches submitted by you.
I am not comfortable with merging this code into 3.3 unless someone takes
a look at the issue with
{{{
Warning: this should never happen
}}}
One last thing: Disregard my comment above. You don't even need to make
the result of abs an int since in either case it returns integer:
{{{
sage: type(M.determinant().abs())
<type 'sage.rings.integer.Integer'>
sage: type(abs(M.determinant()))
<type 'sage.rings.integer.Integer'>
}}}
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3337#comment:44>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
