#3337: [with spkg, needs work] Upgrade gap-guava to new 4.4.12/3.9 release
-------------------------+--------------------------------------------------
Reporter: tabbott | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: packages | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by wdj):
You have a number of incorrect statements. I will list them in order.
> That is because you did not run the documentation
> doctests.
sage -testall runs doctests, so your claim is incorrect. The problem is
that it appears that it does not (for me) print the doctest failures for
the documentation. It used to do that and someone changed the behaviour.
> As I mentioned this is a 32 vs. 64 bit issue. On a
> 64 bit box the tests pass, but not on a 32 bit box.
> Printing Python ints (*not* Sage integers) causes
> issues like that on 32 vs. 64 bit platforms when the
> value is between an in and a long. Just drop the
> int() and you are good to go since in this case
> the determinant returns a Sage integer anyway.
This statement is incorrect for me (amd64 ubuntu 8.10).
Maybe it is true for the machines you test with? As I
said, I think abs may have a bug but in any case I will
change int to ZZ. (I confirmed the type statement you
made before adding the int, this is why I think there is a bug. Maybe the
prepaser is changing things?)
> Maybe you ought to develop patches in branches so
> you don't get unrelated doctest failures like that.
You were the one who suggested I do the testing on sage.math. You can see
from
{{{
http://sage.math.washington.edu/home/wdj/sagefiles/sage-3.3.alpha6/devel/
}}}
that I am using a branch. I've forgotten how long it's been since I've
gotten all doctests to pass! I will try to make that clearer in the future
though.
I'll post a patch with the 2 changes you suggested hopefully in the next
several hours.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3337#comment:47>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
