#3337: [with spkg, needs work] Upgrade gap-guava to new 4.4.12/3.9 release
-------------------------+--------------------------------------------------
Reporter: tabbott | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: packages | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by wdj):
> This is not the problem I am referring to and the print issue were
actual changes in GAP's
> output. These need to be fixed. I have never seen the above statement on
sage.math. Which Sage
> release is this? Do you have anything in .gaprc?
This is sage-3.3.alpha5. No I don't have a .gaprc. Should I?
> This is wrong by the way:
> if [ $UNAME = "CYGWIN" ]; then
> + echo "** Cygwin install not supported **"
> $MKDIR bin
Okay, I'll restore that.
> You also managed to delete .hgignore and not check in the changes to
spkg-install:
Yes, I totally forgot it was an hg repo. Hopefully, when I check it in (or
whatever - I'll have to look up your old emails since I don't remember the
steps), those will get fixed.
> Two more things:
> * spkg-check is missing - since we are now including the GAP test
suite
> (or at least some subset) we need to actually be able to run it
Is there some documentation on what spkg-check should be?
> * SPKG.txt needs to be updated to (a) reflect the changes in
gap-4.4.12.p2.spkg
> and (b) also to spell out the need to remove certain binary crap that
cwitty pointed out.
Okay.
The bigger question for me is that (if we ignore all these problems) it is
not clear to me if the package passes the tests. I don't understand the
"Warning: this should never happen " lines. In other words, I don't know
what they mean or what triggers them. For example, your statement "These
need to be fixed" above. What needs to be fixed? The docstrings in guava?
The print statement in gap.py?
Sorry I haven't had a lot of time to devote to Sage recently. (A lot of
stuff is going on at work.) If this is pressing, if I can't fix this
tomorrow maybe I should ask Carl Witty if he could finish it up?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3337#comment:32>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
