#3337: [with spkg, needs work] Upgrade gap-guava to new 4.4.12/3.9 release
-------------------------+--------------------------------------------------
Reporter: tabbott | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: packages | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by mabshoff):
Replying to [comment:32 wdj]:
Hi David,
> > This is not the problem I am referring to and the print issue were
actual changes in GAP's
> > output. These need to be fixed. I have never seen the above statement
on sage.math. Which Sage
> > release is this? Do you have anything in .gaprc?
>
> This is sage-3.3.alpha5. No I don't have a .gaprc. Should I?
No, but I do not have a .gaprc and I do not see the problem. So if you had
one it could point to the problem.
> > You also managed to delete .hgignore and not check in the changes to
spkg-install:
>
> Yes, I totally forgot it was an hg repo. Hopefully, when I check it in
(or whatever - I'll have to look up your old emails since I don't remember
the steps), those will get fixed.
It is simple:
* unpack spkg
* move spkg to new name, i.e. gap-4.4.12.p0 to gap-4.4.12.p1
* change spkg
* hg commit -m "Describe what you did"
* repack spkg
* test spkg
> > Two more things:
> > * spkg-check is missing - since we are now including the GAP test
suite
> > (or at least some subset) we need to actually be able to run it
>
>
> Is there some documentation on what spkg-check should be?
It should invoke the test suite and return "0" when things pass and not
"0". Note that the working directory when spkg-check is invoked is the
same as at the end of spkg-install, so you might want to get the current
working directory at the start of spkg-install and restore it at the end.
> The bigger question for me is that (if we ignore all these problems) it
is not clear to me if the package passes the tests. I don't understand the
"Warning: this should never happen " lines. In other words, I don't know
what they mean or what triggers them. For example, your statement "These
need to be fixed" above. What needs to be fixed? The docstrings in guava?
The print statement in gap.py?
The following is just the simplest example that fails with the new spkg:
{{{
def version(self):
"""
Returns the version of GAP being used.
EXAMPLES:
sage: gap.version()
'4.4.10'
"""
return gap_version()
}}}
If that did not fail for you you are doing something wrong since you are
still running gap 4.4.10 then. There are about a dozen other problems
related to printing and some other things. I did not take a closer look
since it was clear to me that the spkg as is would not go into 3.3 without
someone doing some major work.
> Sorry I haven't had a lot of time to devote to Sage recently. (A lot of
stuff is going on at work.) If this is pressing, if I can't fix this
tomorrow maybe I should ask Carl Witty if he could finish it up?
I can trivially do the one line change that matters in spkg-install, the
point is that someone needs to fix the doctesting issues exposted by gap
4.4.12.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3337#comment:33>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
