#16533: Notebook won't show animations
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-6.3
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin von Gagern  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gagern/ticket/16533b             |  0325ee23e8e339d7ad2a3f36f6c0b03da7a0cafb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by gagern):

 Replying to [comment:28 niles]:
 > Also, I'd like to make sure we keep the
 [http://www.sagemath.org/doc/developer/coding_in_python.html#deprecation
 deprecation policy] in mind (support old syntax for 1 year after warning
 is issued).

 That is a very useful guideline here on how to proceed, thanks a lot! I
 will restore the positional parameters for now. And I just filed #16607
 for a more generic way of deprecating positional parameters, which – if it
 gets accepted – could be applied here as well.

 > I'm not sure if I understand the best way to deal with this kind of
 situation (keyword defaults passed to other methods).  I understand that
 removing duplication is best practice, but I am frustrated when I can't
 read in a docstring what possible keywords a function takes.

 I thought that even when the function only accepts `**kwargs`, the
 docstring should still document the most commonly used keywords. In that
 case, the function signature would be incomplete, but the docsting as a
 whole would (thanks to unfortunate amounds of dupliate text) still
 describe these parameters. I would however welcome some idea on how to
 avoid this duplication as well.

 > The plot functions seem to have some very complex system for dealing
 with keywords, maybe resolving this tension -- is it relevant here?

 I'll have to investigate all the magic asociated with `_sage_argspec_`,
 but now that you mention it, it ''should'' be possible to improve the
 situation here as well. In particular, the `@options` decorator would be
 useful for `show` in any case, since people might have preferences over
 how to view their animations, particularly with respect to format (GIF /
 APNG / WebM / Theora). Having to set these in every call can become
 annoying. Will investigate that.

--
Ticket URL: <http://trac.sagemath.org/ticket/16533#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to