#16533: Notebook won't show animations
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-6.3
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin von Gagern  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gagern/ticket/16533b             |  0325ee23e8e339d7ad2a3f36f6c0b03da7a0cafb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by gagern):

 To be more specific: I think that we probably should avoid a situation
 where a user passed arguments without keywords and these suddenly change
 their meaning, leading to obscure errors. I think, however, that it is
 acceptable to outright reject these calls with a clear indication that
 positional parameters are unsuitable here. All the examples in the
 docstrings use keywords, so we never advertised the positional use. In
 that regard, `save` needs no changes at all. `show` would have to pop two
 items from `kwargs`. I have the change ready to commit locally, but I'll
 await feedback whether you agree on that deliberate breach of backwards
 compatibility.

 Sure, we could include the old positional parameters, and pass them on to
 `save`. One problem here is that we have to repeat default values all over
 the place. If we decide to change the default delay to something else, or
 perhaps to not set a default delay at all for some formats, then there
 will be several places which need modifications. To deal with that, one
 would have to set all defaults to `None` at the outer levels, and replace
 that with the actual default value just where it is actually needed.
 Doable. Would you prefer a modification along these lines?

--
Ticket URL: <http://trac.sagemath.org/ticket/16533#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to