#16533: Notebook won't show animations
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-6.3
      Component:  graphics           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin von Gagern  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gagern/ticket/16533b             |  0325ee23e8e339d7ad2a3f36f6c0b03da7a0cafb
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by niles):

 I'm cc-ing jhpalmieri since he gave positive review to the ticket which
 introduced this regression -- #12827.

 If I understand correctly, the minimal necessary change is to use
 `graphics_filename` in embedded mode of animate.  I've just pushed a
 branch which does this, and the code from the ticket description does show
 an animation in the notebook.

 Branch:
 
[http://git.sagemath.org/sage.git/diff/?id2=develop&id=u/niles/ticket/16533-stopgap
 u/niles/ticket/16533-stopgap]


 I think the other changes discussed here are important, but I don't have
 time right now to understand them fully or review them.  It makes sense
 that the save/show/internal functions of animation objects and other
 graphics objects should be comparable.  But I would need more time to
 think carefully about the best organization.  I'm not sure that the
 proposed treatment of keyword arguments is ideal, for example.

 I propose that we do the most immediate and quick fix to address the
 regression, and continue work on the other enhancements here in another
 ticket with a more appropriate description.  Anyone interested in giving a
 positive review?

 The outline in comment [comment:9] might make for a good organizational
 framework, and the new metaticket could be set to depend on a number of
 different tickets for single issues.

--
Ticket URL: <http://trac.sagemath.org/ticket/16533#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to