#16533: Notebook won't show animations
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.3
Component: graphics | Resolution:
Keywords: | Merged in:
Authors: Martin von Gagern | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/gagern/ticket/16533b | 0325ee23e8e339d7ad2a3f36f6c0b03da7a0cafb
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by gagern):
One more thing to consider: apparently before #12827, one could call
`Animation.gif()` and `Animation.ffmpeg()` to have files displayed in the
notebook. Neither this patch here nor the one from #16573 will restore
that functionality. Only the code path through `Animation.show()` will be
suitable for notebook. If I were to restore that functionality with all my
other modifications in mind, then I'd do so in the `_adjust_savefile`
method I introduce in
[http://git.sagemath.org/sage.git/commit/?id=005b83f2379d786b88f9a6b194dd334c038ea8ca
005b83f] from #16571.
If you want that functionality restored for the next release as well, then
please let me know whether one of you is willing to review patches up to
that. Note that although #16571 is about adding APNG support, the commit
in question occurs before (and in preparation) to that. So you can review
patches up to that if you want to. I could even merge that commit to the
branch for this ticket here, and then add the use of `graphics_filename`
to that.
I myself am not sure that I would want `gif` and `ffmpeg` to show their
results unconditionally (as images instead of e.g. paths). But for the
sake of backwards compatibility it might still be reasonable.
--
Ticket URL: <http://trac.sagemath.org/ticket/16533#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
