#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 40d4cfaa662913ca6795a8a9a598b53cf931809c
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:24 vinceknight]:
> Replying to [comment:22 vdelecroix]:
> > Replying to [comment:21 vinceknight]:
> > > I don't think I was trying to cancel a commit.
> > > I didn't want to lose/rewrite any of the history as I'm not entirely
sure what is wrong and have no idea what is required to fix it.
> >
> > Start a new branch whose ends correspond to what you want. The
reviewer does not care about your workflow. He only needs a clean view on
what has changed! This is ideally done with '''one''' commit.
> >
> > Then during the review process, you might have some remarks from the
reviewer (maybe even a commit) and you might integrate it to the branch.
You provide additional changes in that commit. And you go on until both
the reviewer(s) and you agreed.
>
> Ok. To fix the situation now, do I need to create a new ticket to in
effect overwrite this ticket or would a git push from a newly created
branch do the trick?
No, no, no. Please, do not create any additional tickets. There is no
need.
Git (where branch live) and trac (where tickets live) are two different
things. You can create as many branches as you like, this is your space.
But on trac it is one task for one ticket and it is public.
You should start a new git branch that would be a clean version of the one
you proposed for that ticket. Then you should link the branch to this
ticket (in the field "branch"). How do you use git? Through the "sage
-devel" scripts? The "git trac" command? git and only git?
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
