#16970: Add new plantri spkg
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers:
Authors: Nico Van Cleemput | Work issues:
Report Upstream: N/A | Commit:
Branch: u/nvcleemp | 8808de28c104ef9bd620c86be02bd9e20a2b4469
/plantri-spkg | Stopgaps:
Dependencies: #16972 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hellooooooooo !
Several comments about this branch:
- `def plane_graphs` -> `def planar_graphs` ?
- `Return a generator which creates general plane graphs using the plantri
generator (see [plantri]_)` --> `An iterator over planar graphs using the
plantri generator` ? It makes it more clear that they are not just 'some
planar graphs' but 'all planar graphs' corresponding to the constraints.
Also we try to keep the first line of doc in a function rather short, so
the reference can appear later.
- You should add the new functions to the documentation at the head of
`graph_generators.py` to let everybody know that they exist.
- There seems to be a lot of copy/paste in the three functions. Is there
any reason why they should not all call `planar_graphs` which would do the
parsing ?
- Could you mention that plantri is an optional package and that it has to
be installed first if it is to work at all ? Actually, you can even try to
check first if the package is installed, and raise a useful exception
otherwise "i.e. --> install it"
http://www.sagemath.org/doc/reference/misc/sage/misc/package.html
Thanks for this work ! It will be useful to many people I hope `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16970#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
