#16970: Add new plantri spkg
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers:
Authors: Nico Van Cleemput | Work issues:
Report Upstream: N/A | Commit:
Branch: u/nvcleemp | 8808de28c104ef9bd620c86be02bd9e20a2b4469
/plantri-spkg | Stopgaps:
Dependencies: #16972 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Helloooooo !
> The documentation is currently being extended, but I'm travelling at the
moment so I didn't get as far with this ticket as I hoped to have.
Oh I see I see, I had not even noticed that the ticket was not in
`needs_review`. Sorry for interrupting.
> I thought about making it just one function, but thought that it would
make the meaning of the arguments less obvious to users. Of course, you
could just add an argument `triangulations` and `quadrangulations`, but I
think that having separate methods is a cleaner solution. I could add a
helper function to which the three functions dispatch to factor out the
common code.
Nononnono I agree with that, the four functions are fine ! I was only
talking about the code: why wouldn't the first function call the other
ones so that there is no duplication of code ?
> Concerning the name. Since also graphs with a connectivity lower than 3
can be generated, this function really generates plane graphs, i.e.,
planar graphs together with an embedding, and not just planar graphs. The
graphs are generated up to isomorphism of the plane graph.
Oh, do you mean that the function will output all different embeddings of
non-3-connected planar graphs ? If so that's worth a note/warning in the
doc !
I am still a bit troubled by this distinction between "plane graphs" and
"planar graphs". Especially when the website of plantri/fullgen reads
"planar graph" everywhere.
http://cs.anu.edu.au/~bdm/plantri/
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16970#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
