#16970: Add new plantri spkg
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers:
Authors: Nico Van Cleemput | Work issues:
Report Upstream: N/A | Commit:
Branch: u/nvcleemp | 8808de28c104ef9bd620c86be02bd9e20a2b4469
/plantri-spkg | Stopgaps:
Dependencies: #16972 |
-------------------------------------+-------------------------------------
Comment (by nvcleemp):
Hi
> Oh I see I see, I had not even noticed that the ticket was not in
`needs_review`. Sorry for interrupting.
Not a problem. It's always good to have some comments along the way.
> Nononnono I agree with that, the four functions are fine ! I was only
talking about the code: why wouldn't the first function call the other
ones so that there is no duplication of code ?
That's true. I'll have a look at fixing that.
> Oh, do you mean that the function will output all different embeddings
of non-3-connected planar graphs ? If so that's worth a note/warning in
the doc !
Yes, it will do that.
> I am still a bit troubled by this distinction between "plane graphs" and
"planar graphs". Especially when the website of plantri/fullgen reads
"planar graph" everywhere.
>
> http://cs.anu.edu.au/~bdm/plantri/
Yes, I know. I actually don't know which notation Brendan uses, but I at
least know that Gunnar is quite adamant about the distinction. I think
they just never got around to changing it from the original wording.
But I can live with planar_graphs if it is noted clearly that for
non-3-connected graphs each distinct planar embedding will be output.
At the moment I'm too jet-lagged to risk writing any code. (Unless you
want some extra work as a reviewer ;-)) I'll continue work on this ticket
soon.
Nico
--
Ticket URL: <http://trac.sagemath.org/ticket/16970#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
