#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | 03f007c702d2baf546f00442f60ee941795789d8
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:357 jdemeyer]:
> Why is there duplication of `Envelope` and `_upper_envelope`?
The role of `_upper_envelope` is to slightly tweak the global ceiling
(an existing already smoothed `Envelope` object) to take into account
the additional local constraint that the current value at position `j`
is `m`. Similarly for `_lower_envelope`.
So the two features are similar in the nature of their goal, but
differ in what they actually need to do to achieve it. So merging them
is unlikely to save any duplication while likely to add complexity.
On the other hand, I agree it would be nice to better clarify this
distinction between the two features in the method names. Suggestions
welcome.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=03f007c702d2baf546f00442f60ee941795789d8
03f007c]||{{{17979: improved doc of lower/upper_envelope}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:379>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
