#9245: Add library of toric varieties
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: new
Priority: major | Milestone:
Component: algebraic geometry | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
I think all fans should have `check=False` option at construction, since
you know what you are doing and the input should be correct. Also, after
constructing the fan, but before passing it to the toric variety, it would
be good to set `fan._is_complete = True` when it is indeed true. Perhaps,
to avoid explicit setting of a private attribute (which is going to
migrate to the shared cache of related fans eventually), we should allow
an optional argument to `fan.is_complete(known=None)`, and if it is given,
then we assume that the user indeed knows whether it is true or false and
save it instead of computing, which can be costly. Let me know if you are
OK with it and I'll include it into the final version of #8987.
With these tweaks there should be no need for pickling as everything
should be fast enough anyway (and pickled objects are not allowed into the
Sage tarball anymore, so either we will need to have an spkg constructing
them, or will have to save them on the first run).
The last five names are very cryptic, but I suppose it can be OK, if they
are eventually described in the docstring.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9245#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
