#9245: Add library of toric varieties
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: new
Priority: major | Milestone:
Component: algebraic geometry | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------------+-----------------------------------------
Comment(by novoselt):
Replying to [comment:2 vbraun]:
> I agree about disabling checks eventually, but for now I think its good
to catch potential bugs elsewhere.
Good point!
> Instead of repurposing `fan.is_complete()`, how about an extra optional
argument to `RationalPolyhedralFan.__init__(assume_complete=False)`.
OK!
> Once `Fan` is finished I can migrate the construction from `Fan` to
`RationalPolyhedralFan` to speed things up further.
That can make things fragile and lead to extra works of putting rays into
proper spaces and making them immutable. That's exactly what `Fan(...,
check=False)` is taking care of, if it does it in a slow way - it is a bug
that should be fixed ;-)
It may be a good idea to keep a dictionary of these named varieties, so
that repetitive calls to, say, `P1xP1` will return the same object.
Another option is to make `ToricVariety` to return unique varieties if
they were already constructed before, but it can be quite tedious compared
to affine and projective spaces.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9245#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
