#9523: Upgrade the Readline spkg to 6.1
----------------------------------------------+-----------------------------
Reporter: cwitty | Owner: tbd
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.6.1
Component: packages | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Florent Hivert, Leif Leonhardy | Merged: sage-4.6.1.alpha0
Work_issues: |
----------------------------------------------+-----------------------------
Comment(by drkirkby):
Replying to [comment:35 jdemeyer]:
> "presidence" sould be "precedence"
>
> Why is {{{patches/shobj-conf}}} under revision control? I believe it is
sufficient for the patch file to be under revision control (but putting
the ''patched'' files also under revision control might be the usual Sage
practice).
It is practice to put both. The argument I've heard for doing this is that
if the only the patch file is under revision control, if a package gets
updated, then the patch is against a version of the source not in the
package. So you need to download the old version.
I'm not totally convinced of the logic myself, but it is standard
practice. (I'd personally rather just see a patch file, and use 'patch'
rather than 'cp', but that is not permitted).
> I don't like {{{"$CC" -flags > /dev/null 2>&1}}} ({{{spkg-install}}}
line 43) for various reasons:
> * I don't think $CC is supposed to be quoted because people might do
things like CC="gcc -m64"
That would not change the results of the test. I can assure you that works
with and without -m64.
> * You should redirect stdin from {{{/dev/null}}} in case $CC wants to
read from stdin.
I'm unaware of any problems with the current code.
> * Instead of checking for Sun's compiler, why not check explicitly for
{{{gcc}}} using
> {{{
> $CC </dev/null >/dev/null 2>/dev/null --version |grep >/dev/null gcc
> }}}
I forget why, but there was some reason that I did not use the obvious
'gcc --version'. Several compilers act like gcc, but are not actually gcc.
I believe the Intel compiler takes the gcc options, so for practical
purposes is gcc, but wont output gcc. In any case, I think one can change
that string when gcc is built to whatever you want.
However, if someone wants to change the test, then the most sensible thing
to do is use the script $SAGE_LOCAL/bin/testcc.sh, as that will return one
of
* GCC
* Sun_Studio
* HP_on_Tru64
* IBM_on_AIX
* HP_on_Alpha_Linux
* Unknown
That tests what gets defined when (!__SUNPRO_C in the case of the Sun
compiler, !__GNUC!__ in the case of gcc etc).
There are bugs that I'm aware of, that are causing serious problems -
#9040 and #9840 are two I would love to solve. I'm reluctant to make a
change, which itself has a finite risk of introducing a bug, to "solve" a
problem that has never been observed. That bit of code has remained
unchanged for a long time, and has never caused any problem on any
platform.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9523#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
