#9523: Upgrade the Readline spkg to 6.1
----------------------------------------------+-----------------------------
Reporter: cwitty | Owner: tbd
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.6.1
Component: packages | Keywords:
Author: David Kirkby | Upstream: N/A
Reviewer: Florent Hivert, Leif Leonhardy | Merged: sage-4.6.1.alpha0
Work_issues: |
----------------------------------------------+-----------------------------
Comment(by jdemeyer):
"presidence" sould be "precedence"
Why is {{{patches/shobj-conf}}} under revision control? I believe it is
sufficient for the patch file to be under revision control (but putting
the ''patched'' files also under revision control might be the usual Sage
practice).
I don't like {{{"$CC" -flags > /dev/null 2>&1}}} ({{{spkg-install}}} line
43) for various reasons:
* I don't think $CC is supposed to be quoted because people might do
things like CC="gcc -m64"
* You should redirect stdin from {{{/dev/null}}} in case $CC wants to
read from stdin.
* Instead of checking for Sun's compiler, why not check explicitly for
{{{gcc}}} using
{{{
$CC </dev/null >/dev/null 2>/dev/null --version |grep >/dev/null gcc
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9523#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
