#9976: Decorated functions/methods have generic signature in documentation
--------------------------------+-------------------------------------------
   Reporter:  jsrn              |       Owner:  mvngu                           
        
       Type:  enhancement       |      Status:  needs_review                    
        
   Priority:  major             |   Milestone:  sage-4.7                        
        
  Component:  documentation     |    Keywords:  sphinx, documentation, cython 
inspection
     Author:  jsrn, Simon King  |    Upstream:  N/A                             
        
   Reviewer:                    |      Merged:                                  
        
Work_issues:                    |  
--------------------------------+-------------------------------------------

Comment(by SimonKing):

 Replying to [comment:53 jsrn]:
 > > That patch also contains the fix for plots: An `AttributeError` is
 raised, not a `KeyError` (and it is tested, of course).
 >
 > I also did that, so more double work. My patch was slightly different: I
 added doc-tests demonstrating the different exception class with different
 access methods (maps.punk vs maps['punk']). I also used
 self.__class__.__name__ instead of type(self) for the output string. I
 don't particularly feel strongly for either, though.

 That might actually be a good idea. It would coincide with what
 sage.structure.parent.raise_attribute_error does. Moreover, I just saw
 that I actually forgot to add a new doctest (although there is a modified
 old doctest showing the error).

 So, perhaps one of us (hopefully not both...) could add it. Perhaps you? I
 plan to move on to ticket #11115.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9976#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to