#11900: Serious regression caused by #9138
-------------------------------------------------+--------------------------
Reporter: SimonKing | Owner: tbd
Type: defect | Status: needs_work
Priority: critical | Milestone: sage-4.8
Component: performance | Keywords: categories
regression
Work_issues: Update reviewer patch | Upstream: N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry | Author: Simon King,
Nicolas M. Thiéry
Merged: | Dependencies: #9138
#11911 #9562
-------------------------------------------------+--------------------------
Comment(by nthiery):
Replying to [comment:175 SimonKing]:
> First error: By my patch, `_value` is a cdef attribute of constant
functions, thus, one can not access it in a doc test. Therefore, I had
changed the corresponding doctest. But your patch re-introduces that test.
Ah, I see, that was the rationale! Sorry; I'll redo my undo :-)
> Second error: There is one error message saying "base ring must be a
field." But your reviewer patch changes one example, so that the same
error message is expected ''without'' the dot in the end.
Ok, will do when the upgrade/compilation will be over (but that will be
tomorrow)
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:179>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
