#11900: Serious regression caused by #9138
-------------------------------------------------+--------------------------
   Reporter:  SimonKing                          |          Owner:  tbd         
                 
       Type:  defect                             |         Status:  needs_work  
                 
   Priority:  critical                           |      Milestone:  sage-4.8    
                 
  Component:  performance                        |       Keywords:  categories 
regression        
Work_issues:  Update reviewer patch              |       Upstream:  N/A         
                 
   Reviewer:  Jeroen Demeyer, Nicolas M. Thiéry  |         Author:  Simon King, 
Nicolas M. Thiéry
     Merged:                                     |   Dependencies:  #9138 
#11911 #9562           
-------------------------------------------------+--------------------------

Comment(by SimonKing):

 Replying to [comment:180 nthiery]:
 >  - remove all chunks in the resulting patch about Finite*

 I don't understand this one. Do you mean, I shall remove doctest stuff
 such as
 {{{
 +        sage: Category.join((Modules(ZZ), FiniteFields()), as_list=True)
 +        [Category of modules over Integer Ring, Category of finite
 fields]
 }}}
 {{{
 +        sage:
 sage.categories.algebra_functor.AlgebrasCategory.category_of(FiniteMonoids(),
 QQ)
 +        Category of monoid algebras over Rational Field
 }}}
 or also this:
 {{{
 -class FiniteCoxeterGroups(Category):
 +class FiniteCoxeterGroups(Category_singleton):
 }}}
 and
 {{{
 -class FiniteCrystals(Category):
 +class FiniteCrystals(Category_singleton):
 }}}
 ?

 >  - CartesianProducts.base: did not we decide to remove it? I don't
 remember; do as you feel appropriate

 I think we said that it should be fine for base_ring at least. But I think
 we also said that this ticket should work stand-alone, and resulting messy
 code will be taken care of in #11943 and #11935.

 Let's see what breaks when I remove that method.

 >  - EXAMPLE:: -> EXAMPLES::

 Sorry, I produced rather many `EXAMPLE::`s.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:181>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to