#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
Reporter: SimonKing | Owner:
tbd
Type: defect | Status:
positive_review
Priority: critical | Milestone:
sage-4.8
Component: performance | Keywords:
categories regression
Work_issues: Update reviewer patch | Upstream:
N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry, Simon King | Author:
Simon King
Merged: | Dependencies:
#9138 #11911 #9562
-------------------------------------------------------------+--------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* author: Simon King, Nicolas M. Thiéry => Simon King
Comment:
Replying to [comment:186 SimonKing]:
> I have attached two patches. Both of them combine the ideas of Nicolas
and myself. The `base()` method is left in; this shall be taken care of at
#11943 (I'll mark it as "todo" there, if it hasn't already been done).
> The final reviewer (i.e., Nicolas, I presume) should decide whether we
want to have
[attachment:trac11900_category_speedup_combined_Finitesingleton.patch] or
[attachment:trac11900_category_speedup_combined.patch].
Since the timing are not decisive in one direction or the other, I
vote for [attachment:trac11900_category_speedup_combined.patch] which
reduces the risks of conflicts with #10963. I have just been through
all of it, and it is good enough to go.
Positive review! Thanks for all your hard work!
PS for the release manager: I haven't run myself the tests since alpha3
segfaults on my Ubuntu 11.10 box.
PS for Simon: Just a remark for next time: in a patch which is likely to
conflict
with other patches lying around on the same topics, please refrain
from doing syntactical improvements (like EXAMPLE -> EXAMPLES) in
chunks where nothing else is changed otherwise. Also, the workaround
for super(Fields).__contains__ in Fields is a code smell. We should
instead find a way to make our Cython __contains__ behave properly
with inheritance. In a future patch!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:187>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
