#11900: Serious regression caused by #9138
-------------------------------------------------+--------------------------
Reporter: SimonKing | Owner: tbd
Type: defect | Status: needs_work
Priority: critical | Milestone: sage-4.8
Component: performance | Keywords: categories
regression
Work_issues: Update reviewer patch | Upstream: N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry | Author: Simon King,
Nicolas M. Thiéry
Merged: | Dependencies: #9138
#11911 #9562
-------------------------------------------------+--------------------------
Comment(by nthiery):
Replying to [comment:179 nthiery]:
> Ok, will do when the upgrade/compilation will be over (but that will be
tomorrow)
Argl, I don't manage to compile alpha3 on my laptop. I sent a mail on
sage-release, but I have no idea how much time this could be. Sorry, but I
am stuck now.
In case you have a bit of spare time, the quickest would be for you to
take over. What needs to be done:
- remove the chunk about ConstantFunctions in my reviewer patch
- fold in my reviewer patch in yours
- fix the trivial doctest failure mentionned above
- remove all chunks in the resulting patch about Finite*
- CartesianProducts.base: did not we decide to remove it? I don't
remember; do as you feel appropriate
- EXAMPLE:: -> EXAMPLES::
- There might be a couple `base_checked` options left after my patch;
change those to the standard check=
- Check that all tests pass
And then a last quick check from met, and that will be good to go!
Cheers!
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:180>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
