#9419: Update Developers Guide to state how patches should be made.
-----------------------------+----------------------------------------------
Reporter: drkirkby | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.8
Component: documentation | Keywords: patch doc howto spkgs diff
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by drkirkby):
Replying to [comment:16 jhpalmieri]:
> Replying to [comment:15 drkirkby]:
> > A minor typo, with "an" instead of "a".
> >
> > "so if you are writing an spkg which is not part of the standard"
>
> I will fix that, thanks.
>
> > Personally I would have used:
> >
> {{{
> diff -Naur
> }}}
> >
> > which seems one of the most common ways.
>
> Dave, I'm shocked: this doesn't seem to be Posix-standard usage :)
An argument for including GNU 'patch' command was that it would be
consistent across all systems. The Sun 'patch' command differs
significantly from the GNU one. In such a case, I think we might as well
use the GNU version of diff, which is /usr/bin/gdiff on hawk.
> Also, re `-r`: I think we might want to produce patches just for one
file at a time, although I don't have a strong feeling about this. At
least in the spkgs that I remember, each patch is for a single file.
That could get quite messy if for example you update configure.ac, and
then generate the 'configure' script. It would seem logical to keep one
patch file for any changes that are made to resolve a particular problem.
But I don't have a strong feeling about it.
dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9419#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
