#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
Reporter: SimonKing | Owner:
tbd
Type: defect | Status:
needs_review
Priority: critical | Milestone:
sage-5.0
Component: performance | Keywords:
categories regression
Work_issues: Update reviewer patch | Upstream:
N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry, Simon King | Author:
Simon King
Merged: | Dependencies:
#9138 #11911 #9562
-------------------------------------------------------------+--------------
Comment(by nthiery):
I just had a look at the ``in Rings()`` code. Maybe Cython should be
complaining when trying to assign None to a variable of a given
type. In any cases, testing for None sounds good for the time
being. On the other hand, I am now puzzled by the code just below
(sorry if I missed it before):
{{{
except TypeError: # this is for objects that aren't CategoryObjects
try:
return PyType_IsSubtype(<type>(x.category().parent_class),
self._parent_class_of_category)
except AttributeError:
return False
}}}
If ``x`` is not a category object, does it make sense to call
x.category()? Shouldn't this just always return False? Otherwise,
there should be an example in the doctests illustrating this.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:198>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
