#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
Reporter: SimonKing | Owner:
tbd
Type: defect | Status:
needs_review
Priority: critical | Milestone:
sage-5.0
Component: performance | Keywords:
categories regression
Work_issues: Update reviewer patch | Upstream:
N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry, Simon King | Author:
Simon King
Merged: | Dependencies:
#9138 #11911 #9562
-------------------------------------------------------------+--------------
Changes (by SimonKing):
* status: needs_work => needs_review
Comment:
I have updated my patch. It is tested whether the argument is None.
If it is not None, then the argument is tried to be assigned to a cdef'ed
variable of type `CategoryObject`. While it is possible to assign None to
it (which is the reason for the segfault), every non-None object that is
not of the right type will produce a type error, which is then caught.
In other words, my fix should be correct. I added a test for the fix.
Needs review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:197>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
