#11900: Serious regression caused by #9138
-------------------------------------------------------------+--------------
   Reporter:  SimonKing                                      |          Owner:  
tbd                  
       Type:  defect                                         |         Status:  
needs_review         
   Priority:  critical                                       |      Milestone:  
sage-5.0             
  Component:  performance                                    |       Keywords:  
categories regression
Work_issues:  Update reviewer patch                          |       Upstream:  
N/A                  
   Reviewer:  Jeroen Demeyer, Nicolas M. ThiƩry, Simon King  |         Author:  
Simon King           
     Merged:                                                 |   Dependencies:  
#9138 #11911 #9562   
-------------------------------------------------------------+--------------

Comment(by SimonKing):

 Replying to [comment:198 nthiery]:
 > I just had a look at the ``in Rings()`` code. Maybe Cython should be
 > complaining when trying to assign None to a variable of a given
 > type.

 I'm not sure. I think the idea is the same as having a point (in C) point
 to NULL.

 > If ``x`` is not a category object, does it make sense to call
 > x.category()?  Shouldn't this just always return False? Otherwise,
 > there should be an example in the doctests illustrating this.

 I guess that is the same problem that hit me in #11521: There are objects
 that aren't `CategoryObject` instances. Any integer is an example.

 I don't remember if actually doc tests would fail if we simplify the code.
 But I guess I wrote that for a reason. Well, let's simply try...

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:199>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to