#12299: Upgrade Jmol to 12.3.27, Advance Jmol Interactive Features in Flask
Notebook
--------------------------------------------------------------+-------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-pending
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503,#13121 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by ddrake):
John Palmieri told me that the testjava.sh shell script is one of the
holdups, and it's not working properly for me on a machine with no Java
installed.
The doctest uses `subprocess.call`, which returns the return code of the
executed program. But `testjava.sh` isn't exiting with useful return
codes. Should the script look like this?
{{{
#!/usr/bin/env bash
# is Java even installed?
type -atp java
if [ $? -gt 0 ]
then
echo Java does not appear to be installed. Exiting.
exit 1
fi
# we support versions 1.5 to 1.7
java -version 2>&1 | grep -q version.*[1]\.[567]
if [ $? -gt 0 ]
then
echo You do not have a supported version of Java. Exiting.
exit 1
fi
echo Java is available and is a supported version.
}}}
Then it gives informative error messages and exits with the proper exit
codes.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:166>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
